[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] pixman: drop submodule
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH] pixman: drop submodule |
Date: |
Mon, 04 Sep 2017 08:31:18 +0200 |
Hi,
> > diff --git a/configure b/configure
> > index dd73cce62f..73760430b0 100755
> > --- a/configure
> > +++ b/configure
> > @@ -930,8 +930,6 @@ for opt do
> > ;;
> > --with-system-pixman) pixman="system"
>
> Is there any use case for '--with-system-pixman now?
There is "--without-pixman" (so you can turn off pixman if you don't
want build the system emulation). So IMHO it makes sense to leave the
opposite switch in. The name is a bit strange now, but changing it
might break build scripts, so I left it as-is. Maybe configure should
accept both "--with-pixman" and "--with-system-pixman"?
cheers,
Gerd