[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 3/7] Convert single line fprintf(.../n) to wa
From: |
James Hogan |
Subject: |
Re: [Qemu-devel] [PATCH v3 3/7] Convert single line fprintf(.../n) to warn_report() |
Date: |
Fri, 1 Sep 2017 21:52:07 +0100 |
User-agent: |
Mutt/1.7.2 (2016-11-26) |
On Fri, Sep 01, 2017 at 09:51:15AM -0700, Alistair Francis wrote:
> diff --git a/target/mips/kvm.c b/target/mips/kvm.c
> index 3317905e71..a23aa438d2 100644
> --- a/target/mips/kvm.c
> +++ b/target/mips/kvm.c
> @@ -95,11 +95,11 @@ void kvm_mips_reset_vcpu(MIPSCPU *cpu)
> CPUMIPSState *env = &cpu->env;
>
> if (!kvm_mips_fpu_cap && env->CP0_Config1 & (1 << CP0C1_FP)) {
> - fprintf(stderr, "Warning: KVM does not support FPU, disabling\n");
> + warn_report("KVM does not support FPU, disabling");
> env->CP0_Config1 &= ~(1 << CP0C1_FP);
> }
> if (!kvm_mips_msa_cap && env->CP0_Config3 & (1 << CP0C3_MSAP)) {
> - fprintf(stderr, "Warning: KVM does not support MSA, disabling\n");
> + warn_report("KVM does not support MSA, disabling");
> env->CP0_Config3 &= ~(1 << CP0C3_MSAP);
> }
That looks sensible.
Reviewed-by: James Hogan <address@hidden> [mips]
The 3 fprintfs in kvm_mips_update_state() are also pretty much non-fatal
warnings too (though only because old kernels v3.10-v3.15 didn't
implement the timer saving API). Feel free to convert those too if you
like, otherwise I'll submit along with some other changes.
Cheers
James
signature.asc
Description: Digital signature
- [Qemu-devel] [PATCH v3 0/7] More warning reporting fixed, Alistair Francis, 2017/09/01
- [Qemu-devel] [PATCH v3 1/7] hw/i386: Improve some of the warning messages, Alistair Francis, 2017/09/01
- [Qemu-devel] [PATCH v3 2/7] Convert remaining error_report() to warn_report(), Alistair Francis, 2017/09/01
- [Qemu-devel] [PATCH v3 3/7] Convert single line fprintf(.../n) to warn_report(), Alistair Francis, 2017/09/01
- Re: [Qemu-devel] [PATCH v3 3/7] Convert single line fprintf(.../n) to warn_report(),
James Hogan <=
- [Qemu-devel] [PATCH v3 5/7] General warn report fixups, Alistair Francis, 2017/09/01
- [Qemu-devel] [PATCH v3 6/7] Makefile: Remove libqemustub.a, Alistair Francis, 2017/09/01
- [Qemu-devel] [PATCH v3 7/7] Convert remaining single line fprintf() to warn_report(), Alistair Francis, 2017/09/01
- [Qemu-devel] [PATCH v3 4/7] Convert multi-line fprintf() to warn_report(), Alistair Francis, 2017/09/01
- Re: [Qemu-devel] [PATCH v3 0/7] More warning reporting fixed, no-reply, 2017/09/01