[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 3/5] qxl: drop mono cursor support
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PULL 3/5] qxl: drop mono cursor support |
Date: |
Fri, 1 Sep 2017 14:57:40 +0200 |
The chunk size sanity check in qxl_render_cursor works for
SPICE_CURSOR_TYPE_ALPHA cursors only. So support for
SPICE_CURSOR_TYPE_MONO cursors must be broken for ages without anyone
noticing. Most likely it simply isn't used any more by guest drivers.
Drop the dead code.
Signed-off-by: Gerd Hoffmann <address@hidden>
Message-id: address@hidden
---
hw/display/qxl-render.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/hw/display/qxl-render.c b/hw/display/qxl-render.c
index 9ad9d9e0f5..e1b3f05ecb 100644
--- a/hw/display/qxl-render.c
+++ b/hw/display/qxl-render.c
@@ -207,7 +207,6 @@ void qxl_render_update_area_done(PCIQXLDevice *qxl,
QXLCookie *cookie)
static QEMUCursor *qxl_cursor(PCIQXLDevice *qxl, QXLCursor *cursor)
{
QEMUCursor *c;
- uint8_t *image, *mask;
size_t size;
c = cursor_alloc(cursor->header.width, cursor->header.height);
@@ -221,14 +220,6 @@ static QEMUCursor *qxl_cursor(PCIQXLDevice *qxl, QXLCursor
*cursor)
cursor_print_ascii_art(c, "qxl/alpha");
}
break;
- case SPICE_CURSOR_TYPE_MONO:
- mask = cursor->chunk.data;
- image = mask + cursor_get_mono_bpl(c) * c->width;
- cursor_set_mono(c, 0xffffff, 0x000000, image, 1, mask);
- if (qxl->debug > 2) {
- cursor_print_ascii_art(c, "qxl/mono");
- }
- break;
default:
fprintf(stderr, "%s: not implemented: type %d\n",
__FUNCTION__, cursor->header.type);
--
2.9.3
- [Qemu-devel] [PULL 0/5] Vga 20170901 patches, Gerd Hoffmann, 2017/09/01
- [Qemu-devel] [PULL 5/5] vga/migration: Update memory map in post_load, Gerd Hoffmann, 2017/09/01
- [Qemu-devel] [PULL 1/5] vga: fix display update region calculation (split screen), Gerd Hoffmann, 2017/09/01
- [Qemu-devel] [PULL 4/5] qxl: add support for chunked cursors., Gerd Hoffmann, 2017/09/01
- [Qemu-devel] [PULL 3/5] qxl: drop mono cursor support,
Gerd Hoffmann <=
- [Qemu-devel] [PULL 2/5] vga: stop passing pointers to vga_draw_line* functions, Gerd Hoffmann, 2017/09/01
- Re: [Qemu-devel] [PULL 0/5] Vga 20170901 patches, Philippe Mathieu-Daudé, 2017/09/01