[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v19 0/2] virtio-crypto: virtio crypto device spe
From: |
Halil Pasic |
Subject: |
Re: [Qemu-devel] [PATCH v19 0/2] virtio-crypto: virtio crypto device specification |
Date: |
Fri, 1 Sep 2017 13:45:45 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 |
On 09/01/2017 02:47 AM, Longpeng (Mike) wrote:
> Ping...
>
> Stefan, Halil, do you have any suggestion ?
>
Hi Longpeng,
I've ran trough your patch, and it reads much better that
what I recall v18 used to read like. Because it's been a while
since v18 doing a conscious review on this will take a considerable
amount of time (my memories of the issues identified back then
are very sketchy/vague now). It's on my todo list, but it ain't the
only item there.
Btw. I like to have a reference implementation at hand when reviewing
a spec. What is the status of the (reference) implementation (I mean
the new stuff like stateless/mux)? I think it would be nice to provide
this info in the cover letter (e.g. next time, should we need another
iteration).
Regards,
Halil
- Re: [Qemu-devel] [PATCH v19 0/2] virtio-crypto: virtio crypto device specification,
Halil Pasic <=