[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 5/9] IDE: replace DEBUG_AIO with trace events
From: |
John Snow |
Subject: |
Re: [Qemu-devel] [PATCH v3 5/9] IDE: replace DEBUG_AIO with trace events |
Date: |
Thu, 31 Aug 2017 20:40:28 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 08/31/2017 08:27 PM, Philippe Mathieu-Daudé wrote:
> On 08/31/2017 09:14 PM, John Snow wrote:
>> Signed-off-by: John Snow <address@hidden>
>
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
>
TY, and btw the reasoning behind what I went with:
Since s->dma_cmd is itself a type `enum ide_dma_cmd` then by definition
s->dma_cmd (even if corrupted or wrong) must fit inside the width of
that type. Performing the range checking in the getter is adequate for
protecting the table in this case, if I understand Laszlo's rationales
correctly.
In case case of the AHCI table, I do not use a getter since the IRQBIT
property is passed in statically for each instance and shouldn't have a
chance to get out-of-spec. (If it does, something MASSIVELY bad has
corrupted everything, and then we've got worse problems.)
Thanks,
John
- [Qemu-devel] [PATCH v3 0/9] IDE: replace printfs with tracing, John Snow, 2017/08/31
- [Qemu-devel] [PATCH v3 1/9] IDE: replace DEBUG_IDE with tracing system, John Snow, 2017/08/31
- [Qemu-devel] [PATCH v3 2/9] IDE: Add register hints to tracing, John Snow, 2017/08/31
- [Qemu-devel] [PATCH v3 3/9] IDE: add tracing for data ports, John Snow, 2017/08/31
- [Qemu-devel] [PATCH v3 4/9] ATAPI: Replace DEBUG_IDE_ATAPI with tracing events, John Snow, 2017/08/31
- [Qemu-devel] [PATCH v3 5/9] IDE: replace DEBUG_AIO with trace events, John Snow, 2017/08/31
- [Qemu-devel] [PATCH v3 7/9] AHCI: Rework IRQ constants, John Snow, 2017/08/31
- [Qemu-devel] [PATCH v3 6/9] AHCI: Replace DPRINTF with trace-events, John Snow, 2017/08/31
- [Qemu-devel] [PATCH v3 8/9] AHCI: pretty-print FIS to buffer instead of stderr, John Snow, 2017/08/31
- [Qemu-devel] [PATCH v3 9/9] AHCI: remove DPRINTF macro, John Snow, 2017/08/31
- Re: [Qemu-devel] [PATCH v3 0/9] IDE: replace printfs with tracing, no-reply, 2017/08/31