Re: [Qemu-devel] [PATCH 0/8] tcg/s390 improvements

[Cornelia Huck]

On Wed, 30 Aug 2017 13:14:03 +0200
Cornelia Huck <address@hidden> wrote:

> On Tue, 29 Aug 2017 13:47:51 -0700
> Richard Henderson <address@hidden> wrote:
> 
> > This finally converts s390 to the tcg_target_op_def function, which
> > allows constraints to vary at runtime.  Once we have that, we can
> > 
> > (1) Perform some facilities checks once during startup instead of
> >     every time we evaluate the constraint,
> > (2) Use the distinct-operands facility from z196.
> > 
> > In addition, two cleanups to the setcond expansion
> > 
> > (3) Use the load-on-condition-2 facility from z13,
> > (4) Use a smaller expansion for LE/LEU using SLBGR.
> > 
> > I wrote these after soft freeze and before I changed jobs, so it has
> > seen some testing.  Unfortunately, I no longer have access to s390
> > hardware, so I'd appreciate it if someone could re-test this rebase.  
> 
> FWIW, this passes my smoketests.
> 
> Looking at the patches now...

That might have been a mistake :)

The parts that I managed to at least superficially understand looked
fine, though; so feel free to add

Acked-by: Cornelia Huck <address@hidden>