[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 16/26] qapi: add conditions to VNC type/commands
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-devel] [PATCH 16/26] qapi: add conditions to VNC type/commands/events on the schema |
Date: |
Tue, 29 Aug 2017 06:46:06 -0400 (EDT) |
Hi
----- Original Message -----
> On Thu, Aug 17, 2017 at 09:04:38AM +0200, Markus Armbruster wrote:
> > Copying our resident VNC maintainer^Wodd fixer Gerd.
> >
> > Also copying Dan for QCryptoCipherAlgorithm.
> >
> > Gerd, Dan, this patch is about making VNC support visible in
> > query-qmp-schema, by having the QAPI generators generate suitable
> > ifdeffery. Bonus: no need for QMP command stubs for
> > !defined(CONFIG_VNC).
>
> [snip]
>
> > * QCryptoCipherAlgorithm
> >
> > This:
> >
> > # @des-rfb: RFB specific variant of single DES. Do not use except in
> > VNC.
> >
> > I guess we could compile this out if we wanted to. I doubt we do, but
> > Dan might have other ideas.
>
> It isn't worth the effort to make that conditionally compiled. We getting
> DES from nettle/gcrypt these days, instead of our custom in-tree desrfb.c
> file, so its no burden to have it.
fyi, the last iteration of the patch made it conditional too.