[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 08/14] apic: add function to apic that will be u
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 08/14] apic: add function to apic that will be used by hvf |
Date: |
Tue, 29 Aug 2017 10:36:48 +0100 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
On Sun, Aug 27, 2017 at 08:56:48PM -0500, Sergio Andres Gomez Del Real wrote:
> This commit moves (hides) the function apic_get_highest_priority_irr to
> apic.c and exports it through the interface in apic.h for use by hvf.
I don't see a move. This patch only adds a new function. Did you
forget to delete the old function?
> Signed-off-by: Sergio Andres Gomez Del Real <address@hidden>
> ---
> hw/intc/apic.c | 11 +++++++++++
> include/hw/i386/apic.h | 1 +
> 2 files changed, 12 insertions(+)
>
> diff --git a/hw/intc/apic.c b/hw/intc/apic.c
> index fe15fb6024..3de59d07fd 100644
> --- a/hw/intc/apic.c
> +++ b/hw/intc/apic.c
> @@ -305,6 +305,17 @@ static void apic_set_tpr(APICCommonState *s, uint8_t val)
> }
> }
>
> +int apic_get_highest_priority_irr(DeviceState *dev)
> +{
> + APICCommonState *s;
> +
> + if (!dev) {
> + return -1;
> + }
> + s = APIC_COMMON(dev);
> + return get_highest_priority_int(s->irr);
> +}
> +
> static uint8_t apic_get_tpr(APICCommonState *s)
> {
> apic_sync_vapic(s, SYNC_FROM_VAPIC);
> diff --git a/include/hw/i386/apic.h b/include/hw/i386/apic.h
> index ea48ea9389..a9f6c0aa33 100644
> --- a/include/hw/i386/apic.h
> +++ b/include/hw/i386/apic.h
> @@ -20,6 +20,7 @@ void apic_init_reset(DeviceState *s);
> void apic_sipi(DeviceState *s);
> void apic_poll_irq(DeviceState *d);
> void apic_designate_bsp(DeviceState *d, bool bsp);
> +int apic_get_highest_priority_irr(DeviceState *dev);
>
> /* pc.c */
> DeviceState *cpu_get_current_apic(void);
> --
> 2.14.1
>
>
- [Qemu-devel] [PATCH 01/14] hvf: add support for Hypervisor.framework in the configure script, (continued)
- [Qemu-devel] [PATCH 01/14] hvf: add support for Hypervisor.framework in the configure script, Sergio Andres Gomez Del Real, 2017/08/27
- [Qemu-devel] [PATCH 03/14] hvf: add conditional macros around hvf code in cpus.c, Sergio Andres Gomez Del Real, 2017/08/27
- [Qemu-devel] [PATCH 04/14] hvf: add fields to CPUState and CPUX86State; add definitions, Sergio Andres Gomez Del Real, 2017/08/27
- [Qemu-devel] [PATCH 06/14] hvf: add compilation rules to Makefile.objs, Sergio Andres Gomez Del Real, 2017/08/27
- [Qemu-devel] [PATCH 05/14] hvf: use new helper functions for put/get xsave, Sergio Andres Gomez Del Real, 2017/08/27
- [Qemu-devel] [PATCH 08/14] apic: add function to apic that will be used by hvf, Sergio Andres Gomez Del Real, 2017/08/27
- Re: [Qemu-devel] [PATCH 08/14] apic: add function to apic that will be used by hvf,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH 09/14] hvf: implement hvf_get_supported_cpuid, Sergio Andres Gomez Del Real, 2017/08/27
- [Qemu-devel] [PATCH 11/14] hvf: implement vga dirty page tracking, Sergio Andres Gomez Del Real, 2017/08/27
- [Qemu-devel] [PATCH 10/14] hvf: refactor cpuid code, Sergio Andres Gomez Del Real, 2017/08/27
- [Qemu-devel] [PATCH 14/14] hvf: inject General Protection Fault when vmexit through vmcall, Sergio Andres Gomez Del Real, 2017/08/27
- [Qemu-devel] [PATCH 13/14] hvf: refactor event injection code for hvf, Sergio Andres Gomez Del Real, 2017/08/27
- [Qemu-devel] [PATCH 12/14] hvf: move fields from CPUState to CPUX86State, Sergio Andres Gomez Del Real, 2017/08/27
- [Qemu-devel] [PATCH 02/14] hvf: add code base from Google's QEMU repository, Sergio Andres Gomez Del Real, 2017/08/28