qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 09/16] qapi-schema: Collect migration stuff i


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH v2 09/16] qapi-schema: Collect migration stuff in qapi/migration.json
Date: Mon, 28 Aug 2017 13:22:41 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)

"Dr. David Alan Gilbert" <address@hidden> writes:

> * Markus Armbruster (address@hidden) wrote:
>> Cc: Juan Quintela <address@hidden>
>> Cc: Dr. David Alan Gilbert <address@hidden>
>> Signed-off-by: Markus Armbruster <address@hidden>
>
>
> Two thoughts:
>   a) Do you actually want that as migration/migration.json?

I'd prefer to keep the QAPI schema together.  But that could be my
schema maintainer bias talking :)

>   b) I'd prefer StrOrNull to be somewhere more central; Migration may be
>   the only user, but it's not logically migration specific.

Makes sense.  I'll move it to common.json.

> Reviewed-by: Dr. David Alan Gilbert <address@hidden>

Thanks!



reply via email to

[Prev in Thread] Current Thread [Next in Thread]