[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1 |
Date: |
Fri, 25 Aug 2017 16:04:08 +0200 |
On Fri, 25 Aug 2017 09:24:46 -0400
Farhan Ali <address@hidden> wrote:
> The commit 198c0d1f9df8c4 s390x/css: check ccw address validity
> exposes an alignment issue in ccw bios.
>
> According to PoP the CCW must be doubleword aligned. Let's fix
> this in the bios.
>
> Cc: address@hidden
> Signed-off-by: Farhan Ali <address@hidden>
> Reviewed-by: Halil Pasic <address@hidden>
> Reviewed-by: Eric Farman <address@hidden>
> Acked-by: Christian Borntraeger <address@hidden>
> ---
> pc-bios/s390-ccw/cio.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/pc-bios/s390-ccw/cio.h b/pc-bios/s390-ccw/cio.h
> index f5b4549..55eaeee 100644
> --- a/pc-bios/s390-ccw/cio.h
> +++ b/pc-bios/s390-ccw/cio.h
> @@ -133,7 +133,7 @@ struct ccw1 {
> __u8 flags;
> __u16 count;
> __u32 cda;
> -} __attribute__ ((packed));
> +} __attribute__ ((packed, aligned(8)));
>
> #define CCW_FLAG_DC 0x80
> #define CCW_FLAG_CC 0x40
Currently testing.
This looks obviously right, but did you figure out what the (probably
unrelated) other failure was?
- [Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1, Farhan Ali, 2017/08/25
- Re: [Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1, no-reply, 2017/08/25
- Re: [Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1,
Cornelia Huck <=
- Re: [Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1, Farhan Ali, 2017/08/25
- Re: [Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1, Cornelia Huck, 2017/08/28
- Re: [Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1, Farhan Ali, 2017/08/28
- Re: [Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1, Cornelia Huck, 2017/08/28
- Re: [Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1, Farhan Ali, 2017/08/28
- Re: [Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1, Christian Borntraeger, 2017/08/28
- Re: [Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1, Farhan Ali, 2017/08/28
- Re: [Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1, Cornelia Huck, 2017/08/28
- Re: [Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1, Farhan Ali, 2017/08/28
- Re: [Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1, Halil Pasic, 2017/08/28