[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 00/16] qapi-schema: Reorganize along maintena
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v2 00/16] qapi-schema: Reorganize along maintenance boundaries |
Date: |
Fri, 25 Aug 2017 06:50:38 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 08/24/2017 02:13 PM, Markus Armbruster wrote:
>> Cc: "Daniel P. Berrange" <address@hidden>
>> Cc: Alberto Garcia <address@hidden>
>> Cc: Dr. David Alan Gilbert <address@hidden>
>> Cc: Gerd Hoffmann <address@hidden>
>> Cc: Jason Wang <address@hidden>
>> Cc: Juan Quintela <address@hidden>
>> Cc: Marc-André Lureau <address@hidden>
>> Cc: Paolo Bonzini <address@hidden>
>>
>> Much of the QAPI schema really belongs to a subsystem, but MAINTAINERS
>> can't tell when it's all in a big ball of mud (qapi-schema.json) with
>> a small ball of mud (event.json) on the side.
>>
>> Create sub-schemas for the subsystems with the most substantial QAPI
>> footprint in the mud. The big ball shrinks by half, and the small
>> ball goes away.
>>
>> Bonus: the generated documentation's structure makes more sense now.
>> It needs further improvement (see last patch), but it's a start.
>>
>> I generally kept the order intact when moving source code. It may be
>> smarter to reorder it for improved legibility (both source and
>> generated doc). Subsystem maintainers, please tell me whether you'd
>> like things reordered.
>
> Ideally, moving from one file to another should be kept separate from
> reordering within a file, to make review easier.
I can move in order, then reorder in a separate patch, if that makes
review easier.
Reordering code is always awkward. It's just less awkward when we
reshuffle things anyway.
- [Qemu-devel] [PATCH v2 11/16] qapi-schema: Collect TPM stuff in qapi/tpm.json, (continued)
- [Qemu-devel] [PATCH v2 11/16] qapi-schema: Collect TPM stuff in qapi/tpm.json, Markus Armbruster, 2017/08/24
- [Qemu-devel] [PATCH v2 12/16] qapi-schema: Move block events from event.json to block.json, Markus Armbruster, 2017/08/24
- [Qemu-devel] [PATCH v2 05/16] qapi-schema: Collect run state stuff in qapi/run-state.json, Markus Armbruster, 2017/08/24
- [Qemu-devel] [PATCH v2 10/16] qapi-schema: Collect transaction stuff in qapi/transaction.json, Markus Armbruster, 2017/08/24
- [Qemu-devel] [PATCH v2 06/16] qapi-schema: Collect char device stuff in qapi/char.json, Markus Armbruster, 2017/08/24
- [Qemu-devel] [PATCH v2 08/16] qapi-schema: Collect UI stuff in qapi/ui.json, Markus Armbruster, 2017/08/24
- [Qemu-devel] [PATCH v2 07/16] qapi-schema: Collect net device stuff in qapi/net.json, Markus Armbruster, 2017/08/24
- [Qemu-devel] [PATCH v2 09/16] qapi-schema: Collect migration stuff in qapi/migration.json, Markus Armbruster, 2017/08/24
- Re: [Qemu-devel] [PATCH v2 00/16] qapi-schema: Reorganize along maintenance boundaries, Eric Blake, 2017/08/24
- Re: [Qemu-devel] [PATCH v2 00/16] qapi-schema: Reorganize along maintenance boundaries,
Markus Armbruster <=