Re: [Qemu-devel] [PATCH v6 03/10] qemu.py: Use iteritems rather than keys()

[Cleber Rosa]

On 08/18/2017 10:26 AM, Lukáš Doktor wrote:
> Let's avoid creating an in-memory list of keys and query for each value
> and use `iteritems` which is an iterator of key-value pairs.
> 
> Signed-off-by: Lukáš Doktor <address@hidden>
> Reviewed-by: Eduardo Habkost <address@hidden>
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
>  scripts/qemu.py | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/scripts/qemu.py b/scripts/qemu.py
> index 5d09de4..db21407 100644
> --- a/scripts/qemu.py
> +++ b/scripts/qemu.py
> @@ -186,11 +186,11 @@ class QEMUMachine(object):
>      def qmp(self, cmd, conv_keys=True, **args):
>          '''Invoke a QMP command and return the response dict'''
>          qmp_args = dict()
> -        for key in args.keys():
> +        for key, value in args.iteritems():
>              if conv_keys:
> -                qmp_args[key.translate(self.underscore_to_dash)] = args[key]
> +                qmp_args[key.translate(self.underscore_to_dash)] = value
>              else:
> -                qmp_args[key] = args[key]
> +                qmp_args[key] = value
>  
>          return self._qmp.cmd(cmd, args=qmp_args)
>  
> 

Yep, I could tell this was coming while reading patch 01.

Reviewed-by: Cleber Rosa <address@hidden>

signature.asc
Description: OpenPGP digital signature