Re: [Qemu-devel] S390 bios breaks in qemu 2.10.rc3

[Peter Maydell]

On 24 August 2017 at 16:53, Farhan Ali <address@hidden> wrote:
>
>
> On 08/24/2017 11:50 AM, Thomas Huth wrote:
>> True, so that could still be an issue. Looking at the cio.h in the
>> kernel, they define the struct like this:
>>
>> struct ccw1 {
>>         __u8  cmd_code;
>>         __u8  flags;
>>         __u16 count;
>>         __u32 cda;
>> } __attribute__ ((packed,aligned(8)));
>>
>> So I guess adding the aligned(8) is the right way to go?

> This was my initial fix and it works on my system. But for some reason this
> fix does not work on my colleague's system. So I am hesitant about
> submitting this fix

It seems like it ought to be the obvious fix, so I would double
check that on your colleague's system the change really did
get recompiled and it's actually using the new version (that
sort of mistake can be easy to make and very confusing...)

thanks
-- PMM