Re: [Qemu-devel] [PATCH] hw/misc/auxbus.c: Mark the aux-to-i2c-bridge device as non-hotpluggable

[KONRAD Frederic]

On 08/23/2017 07:22 AM, Thomas Huth wrote:
> On 22.08.2017 20:15, KONRAD Frederic wrote:
> > Hi Thomas,
> >
> > Looking to this seems there is a second issue:
> > The aux-to-i2c-bridge device should connect on a TYPE_AUX_BUS.
> >
> > I don't think there isn't any on integratorcp..
> >
> > Anyway the patch you sent fix this issue indirectly and as far as
> > I remember I wasn't able to make this I2C bridge an
> > TYPE_AUX_DEVICE as it's a special device and it is internal (only
> > instantiated at the bus creation).
>
> If it is intended to be completely internal only (i.e. also not for use
> with the "-device" parameter), then it should even be marked with
> "user_creatable = false"! ... if you got some spare minutes, could you
> maybe sent a patch for that? I'm not familiar with that code, so I'm
> always having trouble to give the reasoning for setting a
> "user_creatable = false" somewhere...
>
>   Thanks,
>    Thomas

Ok will do!

Thanks,
Fred