[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3] hw/acpi-build: Fix SRAT memory building when
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH v3] hw/acpi-build: Fix SRAT memory building when there is no memory in node0 |
Date: |
Fri, 18 Aug 2017 16:20:23 -0300 |
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Fri, Aug 18, 2017 at 09:35:00PM +0300, Michael S. Tsirkin wrote:
> On Wed, Aug 16, 2017 at 09:45:35AM +0800, Dou Liyang wrote:
> > Currently, Using the fisrt node without memory on the machine makes
> > QEMU unhappy. With this example command line:
> > ... \
> > -m 1024M,slots=4,maxmem=32G \
> > -numa node,nodeid=0 \
> > -numa node,mem=1024M,nodeid=1 \
> > -numa node,nodeid=2 \
> > -numa node,nodeid=3 \
> > Guest reports "No NUMA configuration found" and the NUMA topology is
> > wrong.
> >
> > This is because when QEMU builds ACPI SRAT, it regards node0 as the
> > default node to deal with the memory hole(640K-1M). this means the
> > node0 must have some memory(>1M), but, actually it can have no
> > memory.
> >
> > Fix this problem by replace the node0 with the first node which has
> > memory on it. Add a new function for each node. Also do some cleanup.
> >
> > Signed-off-by: Dou Liyang <address@hidden>
>
> This isn't a regression, is it? If it isn't, it's not a 2.10 candidate
> IMHO.
As noted in another reply to v2, I agree and I'm treating it as a
2.11 candidate.
--
Eduardo
Re: [Qemu-devel] [PATCH v3] hw/acpi-build: Fix SRAT memory building when there is no memory in node0, Michael S. Tsirkin, 2017/08/18
- Re: [Qemu-devel] [PATCH v3] hw/acpi-build: Fix SRAT memory building when there is no memory in node0,
Eduardo Habkost <=