[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 for-2.11 04/18] target/s390x: simplify gs_all
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH v3 for-2.11 04/18] target/s390x: simplify gs_allowed() |
Date: |
Fri, 18 Aug 2017 17:59:06 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 |
On 18.08.2017 13:43, David Hildenbrand wrote:
> No need for kvm_enabled() as this function is only called from KVM and
> there is no reason why it shouldn't be allowed for tcg. It is simply not
> available under tcg.
>
> Also, there is no need to check for the machine type anymore. Just like
> ri_enabled(), we can directly use the stored flag, which results in
> "true" for the "none" machine.
>
> Signed-off-by: David Hildenbrand <address@hidden>
> ---
> hw/s390x/s390-virtio-ccw.c | 14 ++------------
> 1 file changed, 2 insertions(+), 12 deletions(-)
Reviewed-by: Thomas Huth <address@hidden>
- [Qemu-devel] [PATCH v3 for-2.11 00/18] target/s390x: cleanup cpu.h, David Hildenbrand, 2017/08/18
- [Qemu-devel] [PATCH v3 for-2.11 01/18] s390x/kvm: drop KVMState parameter from s390_get_memslot_count(), David Hildenbrand, 2017/08/18
- [Qemu-devel] [PATCH v3 for-2.11 02/18] s390x/kvm: drop KVMState parameter from kvm_s390_set_mem_limit(), David Hildenbrand, 2017/08/18
- [Qemu-devel] [PATCH v3 for-2.11 03/18] target/s390x: simplify ri_allowed(), David Hildenbrand, 2017/08/18
- [Qemu-devel] [PATCH v3 for-2.11 04/18] target/s390x: simplify gs_allowed(), David Hildenbrand, 2017/08/18
- Re: [Qemu-devel] [PATCH v3 for-2.11 04/18] target/s390x: simplify gs_allowed(),
Thomas Huth <=
- [Qemu-devel] [PATCH v3 for-2.11 05/18] target/s390x: no need to pass kvm_state to savevm_gtod handlers, David Hildenbrand, 2017/08/18
- [Qemu-devel] [PATCH v3 for-2.11 06/18] s390x/cpumodel: factor out determination of default model name, David Hildenbrand, 2017/08/18
- [Qemu-devel] [PATCH v3 for-2.11 07/18] s390x: drop inclusion of sysemu/kvm.h from some files, David Hildenbrand, 2017/08/18
[Qemu-devel] [PATCH v3 for-2.11 08/18] target/s390x: move gtod_*() declarations to s390-virtio.h, David Hildenbrand, 2017/08/18