|
From: | Philippe Mathieu-Daudé |
Subject: | Re: [Qemu-devel] [PATCH 0/8] QOMify MIPS cpu |
Date: | Thu, 17 Aug 2017 13:34:11 -0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 08/17/2017 01:54 AM, address@hidden wrote:
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: address@hidden Subject: [Qemu-devel] [PATCH 0/8] QOMify MIPS cpu
[...]
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 1557a1941b mips: update mips_cpu_list() to use object_class_get_list() fff05e4786 mips: replace cpu_mips_init() with cpu_generic_init() 78afa559f4 !fixup mips: now than MIPSCPU is QOMified, mark it abstract ff2926570c mips: MIPSCPU model subclasses 36f62a8a0b mips: call cpu_mips_realize_env() from mips_cpu_realizefn() 825094780c mips: split cpu_mips_realize_env() out of cpu_mips_init() 7339de695e mips: introduce internal.h and cleanup cpu.h 011150634e mips: move hw/mips/cputimer.c to target/mips/ === OUTPUT BEGIN === Checking PATCH 1/8: mips: move hw/mips/cputimer.c to target/mips/... Checking PATCH 2/8: mips: introduce internal.h and cleanup cpu.h... ERROR: space prohibited after that '&' (ctx:WxW) #725: FILE: target/mips/internal.h:230: + if ((env->CP0_VPControl >> CP0VPCtl_DIS) & 1) { ^
I doubt CHECKPATCH is correct here, removing the space it'd look like handling pointer address...
ERROR: space prohibited after that '&' (ctx:WxW) #733: FILE: target/mips/internal.h:238: + ((other_cpu->env.CP0_VPControl >> CP0VPCtl_DIS) & 1)) { ^ ERROR: space prohibited after that '&' (ctx:WxW) #753: FILE: target/mips/internal.h:258: + env->hflags |= (env->CP0_Status >> CP0St_KSU) & MIPS_HFLAG_KSU; ^ total: 3 errors, 0 warnings, 842 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 3/8: mips: split cpu_mips_realize_env() out of cpu_mips_init()... Checking PATCH 4/8: mips: call cpu_mips_realize_env() from mips_cpu_realizefn()... Checking PATCH 5/8: mips: MIPSCPU model subclasses... Checking PATCH 6/8: !fixup mips: now than MIPSCPU is QOMified, mark it abstract... Checking PATCH 7/8: mips: replace cpu_mips_init() with cpu_generic_init()... Checking PATCH 8/8: mips: update mips_cpu_list() to use object_class_get_list()... === OUTPUT END ===
[Prev in Thread] | Current Thread | [Next in Thread] |