[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.10???] fix build failure in nbd_read_reply
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH for-2.10???] fix build failure in nbd_read_reply_entry() |
Date: |
Thu, 17 Aug 2017 11:29:59 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 08/17/2017 11:14 AM, Igor Mammedov wrote:
> travis builds fail at HEAD at rc3 master with
>
> block/nbd-client.c: In function ‘nbd_read_reply_entry’:
> block/nbd-client.c:110:8: error: ‘ret’ may be used uninitialized in this
> function [-Werror=uninitialized]
>
> fix it by initializing 'ret' to 0
>
> Signed-off-by: Igor Mammedov <address@hidden>
> ---
> block/nbd-client.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <address@hidden>
I concur that it is a false positive, introduced by commit 72b6ffc7; and
that it should not affect tarball builds where we do not default to
turning on -Werror (other than an annoying warning). This feels to me to
be in the same category as a couple other patches we have already
identified, where it doesn't deserve spinning up -rc4 by itself, but if
we do have a major bug to fix, then including this one at the same time
is fine.
I'll defer to Peter's judgment on whether to apply it for 2.10;
meanwhile, I'll stick it on my NBD tree for 2.11 if it does not get
applied for 2.10.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
Re: [Qemu-devel] [PATCH for-2.10???] fix build failure in nbd_read_reply_entry(),
Eric Blake <=
Re: [Qemu-devel] [PATCH for-2.10???] fix build failure in nbd_read_reply_entry(), Peter Maydell, 2017/08/23