[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC 3/9] qemu.py: Add "wait()" method
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH RFC 3/9] qemu.py: Add "wait()" method |
Date: |
Wed, 16 Aug 2017 09:32:20 +0100 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
On Wed, Aug 16, 2017 at 03:20:58PM +0800, Fam Zheng wrote:
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> scripts/qemu.py | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/scripts/qemu.py b/scripts/qemu.py
> index e5f314efdb..3e7eb44035 100644
> --- a/scripts/qemu.py
> +++ b/scripts/qemu.py
> @@ -144,6 +144,11 @@ class QEMUMachine(object):
> self._post_shutdown()
> raise
>
> + def wait(self):
> + self._popen.wait()
> + self._qmp.close()
> + self._post_shutdown()
> +
Please include docstrings for public methods.
Is this method for users who do not use shutdown() because the guest
halts itself?
Why is self._load_io_log() not called?
Stefan
signature.asc
Description: PGP signature
- [Qemu-devel] [PATCH RFC 0/9] tests: Add VM based build tests (for non-x86_64 and/or non-Linux), Fam Zheng, 2017/08/16
- [Qemu-devel] [PATCH RFC 6/9] tests: Add FreeBSD image, Fam Zheng, 2017/08/16
- [Qemu-devel] [PATCH RFC 7/9] tests: Add NetBSD image, Fam Zheng, 2017/08/16
- [Qemu-devel] [PATCH RFC 8/9] tests: Add OpenBSD image, Fam Zheng, 2017/08/16
- [Qemu-devel] [PATCH RFC 9/9] Makefile: Add rules to run vm tests, Fam Zheng, 2017/08/16
- [Qemu-devel] [PATCH RFC 3/9] qemu.py: Add "wait()" method, Fam Zheng, 2017/08/16
- Re: [Qemu-devel] [PATCH RFC 3/9] qemu.py: Add "wait()" method,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH RFC 4/9] tests: Add vm test lib, Fam Zheng, 2017/08/16
- [Qemu-devel] [PATCH RFC 5/9] tests: Add ubuntu.i386 image, Fam Zheng, 2017/08/16
- [Qemu-devel] [PATCH RFC 2/9] qemu.py: Add variable vga type, Fam Zheng, 2017/08/16
- [Qemu-devel] [PATCH RFC 1/9] gitignore: Ignore vm test images, Fam Zheng, 2017/08/16
- Re: [Qemu-devel] [PATCH RFC 0/9] tests: Add VM based build tests (for non-x86_64 and/or non-Linux), no-reply, 2017/08/16