qemu-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/2] block: use internal filter node in backup

From: Vladimir Sementsov-Ogievskiy
Subject: Re: [Qemu-devel] [PATCH 1/2] block: use internal filter node in backup
Date: Tue, 15 Aug 2017 10:44:15 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 
15.08.2017 09:19, Manos Pitsidianakis wrote:

block/backup.c currently uses before write notifiers on the targeted
node. We can create a filter node instead to intercept write requests
for the backup job on the BDS level, instead of the BlockBackend level.



Hi Manos!
Looks interesting but what is the real benefit of it? It doesn't look like it simplifies the code.. Also, is it affect performance? 
I think it worth describing in commit message.


--
Best regards,
Vladimir
reply via email to
[Prev in Thread] Current Thread [Next in Thread]