[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 04/28] sparc: convert cpu models to SPARC cpu su
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [PATCH 04/28] sparc: convert cpu models to SPARC cpu subclasses |
Date: |
Tue, 15 Aug 2017 09:38:11 +0200 |
On Mon, 14 Aug 2017 18:24:31 +0200
Artyom Tarasenko <address@hidden> wrote:
> Hi Igor,
>
> On Mon, Aug 14, 2017 at 9:56 AM, Igor Mammedov <address@hidden> wrote:
> > On Fri, 14 Jul 2017 15:51:55 +0200
> > Igor Mammedov <address@hidden> wrote:
> >
> >> QOMfy cpu models handling introducing propper cpu types
> >> for each cpu model.
> >>
> >> Signed-off-by: Igor Mammedov <address@hidden>
> >> ---
> >> with this and conversion of features to properties,
> >> it would be possible to replace cpu_sparc_init() with
> >> cpu_generic_init() and reuse common -cpu handling
> >> infrastructure.
> >>
> >> CC: Mark Cave-Ayland <address@hidden>
> >> CC: Artyom Tarasenko <address@hidden>
> >
> > ping,
> >
> > Mark, Artoym,
> >
> > As SPARC maintainers, cloud you please review/test patches 4-10/28.
>
> Will look on it on the upcoming weekend.
>
> > + /* SPARC cpu model names happen to have whitespaces,
> > + * as type names shouldn't have spaces replace them with '-'
> > + */
>
> Does it also happen for non-SPARC cpu model names?
not that I know of, there is nothing we can do about cpu model names
as it's user facing value and fixing them would break user's scripts,
hence target specific quirk in sparc_cpu_class_by_name().
Other targets have their own quirks, like cpu aliases which also
handled on per target basis in foo_cpu_class_by_name() callbacks.
>
> Artyom
>