[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 4/5] libqtest: always set up signal handler for S
From: |
Jens Freimann |
Subject: |
[Qemu-devel] [PATCH v2 4/5] libqtest: always set up signal handler for SIGABRT |
Date: |
Tue, 8 Aug 2017 22:38:59 +0200 |
Currently abort handlers only work for the first test function
in a testcase, because the list of abort handlers is not properly
cleared when qtest_quit() is called.
qtest_quit() only deletes the kill_qemu_hook but doesn't completely
clear the abrt_hooks list. The effect is that abrt_hooks.is_setup is
never set to false and in a following test the abrt_hooks list is not
initialized and setup_sigabrt_handler() is not called.
One way to solve this is to clear the list in qtest_quit(), but
that means only asserts between qtest_start and qtest_quit will
be catched by the abort handler.
We can make abort handlers work in all cases if we always setup the
signal handler for SIGABRT in qtest_init.
Signed-off-by: Jens Freimann <address@hidden>
---
tests/libqtest.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/libqtest.c b/tests/libqtest.c
index 4a5492a603..b9a1f180e1 100644
--- a/tests/libqtest.c
+++ b/tests/libqtest.c
@@ -140,8 +140,8 @@ void qtest_add_abrt_handler(GHookFunc fn, const void *data)
/* Only install SIGABRT handler once */
if (!abrt_hooks.is_setup) {
g_hook_list_init(&abrt_hooks, sizeof(GHook));
- setup_sigabrt_handler();
}
+ setup_sigabrt_handler();
hook = g_hook_alloc(&abrt_hooks);
hook->func = fn;
--
2.13.3
- [Qemu-devel] [PATCH v2 0/5] tests/pxe-test: add testcase using vhost-user-bridge, Jens Freimann, 2017/08/08
- [Qemu-devel] [PATCH v2 2/5] net: fix -netdev socket, fd= for UDP sockets, Jens Freimann, 2017/08/08
- [Qemu-devel] [PATCH v2 3/5] libvhost-user: quit when no more data received, Jens Freimann, 2017/08/08
- [Qemu-devel] [PATCH v2 5/5] tests/pxe-test: add testcase using vhost-user-bridge, Jens Freimann, 2017/08/08
- [Qemu-devel] [PATCH v2 1/5] tests/vhost-user-bridge: disable debug output by default, Jens Freimann, 2017/08/08
- [Qemu-devel] [PATCH v2 4/5] libqtest: always set up signal handler for SIGABRT,
Jens Freimann <=
- Re: [Qemu-devel] [PATCH for-2.10? v2 0/5] tests/pxe-test: add testcase using vhost-user-bridge, Eric Blake, 2017/08/08
- Re: [Qemu-devel] [PATCH v2 0/5] tests/pxe-test: add testcase using vhost-user-bridge, no-reply, 2017/08/08