Re: [Qemu-devel] [PATCH 0/5] ui: keymap fixes for 2.10

[Eric Blake]

On 08/08/2017 04:20 AM, Markus Armbruster wrote:
> Just back from the signed-vs-unsigned swamp, still catching up, sorry
> for the delay...
> 

>>>   File "/var/tmp/patchew-tester-tmp-xs4657r8/src/scripts/qapi2texi.py", 
>>> line 160, in texi_members
>>>     items += member_func(section.member) + desc + '\n'
>>>   File "/var/tmp/patchew-tester-tmp-xs4657r8/src/scripts/qapi2texi.py", 
>>> line 133, in texi_enum_value
>>>     return '@item @code{%s}\n' % value.name
>>> AttributeError: 'NoneType' object has no attribute 'name'
>>
>> Eww, we have a bug in our qapi generator (a stack dump instead of a nice
>> error message).  I suspect this is caused by your use of '@ac_*' instead
>> of spelling out all the ac_ members added in qapi-schema.json in 4/5 -
> 
> Yes, we require doc comments to match the schema.  Wildcards aren't
> supported.  They could be, if we want them badly enough.
> 
>> but it IS something that needs to be fixed on your end to quit tripping
>> up the doc generator.
> 
> Has anyone worked on a fix for qapi2texi.py?

We worked around the generator bug in the meantime, so the qapi2texi.py
bug is still latent (sadly, it's not my highest priority)

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature