Re: [Qemu-devel] [RFC PATCH 14/56] migration: Fix migrate-set-cache-size error reporting

[Juan Quintela]

Markus Armbruster <address@hidden> wrote:
> qmp_migrate_set_cache_size() calls xbzrle_cache_resize() to do the
> actual work, which in turn calls cache_init() to resize the cache.  If
> cache_init() fails, xbzrle_cache_resize() reports that error with
> error_report() and fails.  qmp_migrate_set_cache_size() detects the
> failure and reports "Parameter 'cache size' expects is smaller than
> page size" with error_setg().  The first error is accurate, the second
> is bogus.  With HMP, we get both.  With QMP, we get the accurate one
> on stderr, and the bogus one via QMP.
>
> Fix by making xbzrle_cache_resize() use error_setg() instead of
> error_report().
>
> Signed-off-by: Markus Armbruster <address@hidden>

Reviewed-by: Juan Quintela <address@hidden>