[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 2/7] qemu.py: fix is_running() return before
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v6 2/7] qemu.py: fix is_running() return before first launch() |
Date: |
Tue, 1 Aug 2017 11:09:25 +0100 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
On Mon, Jul 31, 2017 at 10:51:05AM +0200, Amador Pahim wrote:
> is_running() returns None when called before the first time we
> call launch():
>
> >>> import qemu
> >>> vm = qemu.QEMUMachine('qemu-system-x86_64')
> >>> vm.is_running()
> >>>
>
> It should retunt False instead. This patch fixes that.
s/retunt/return/
>
> Signed-off-by: Amador Pahim <address@hidden>
> ---
> scripts/qemu.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/qemu.py b/scripts/qemu.py
> index 2f1984c93c..77565eb092 100644
> --- a/scripts/qemu.py
> +++ b/scripts/qemu.py
> @@ -86,7 +86,7 @@ class QEMUMachine(object):
> raise
>
> def is_running(self):
> - return self._popen and (self._popen.poll() is None)
> + return self._popen is not None and (self._popen.poll() is None)
The parentheses are inconsistent:
return (self._popen is not None) and (self._popen.poll() is None)
An alternative:
return bool(self._popen and self._popen.poll())
signature.asc
Description: PGP signature
- Re: [Qemu-devel] [PATCH v6 2/7] qemu.py: fix is_running() return before first launch(),
Stefan Hajnoczi <=