[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 10/25] qcow2: fix null pointer dereference
From: |
Michael Tokarev |
Subject: |
[Qemu-devel] [PULL 10/25] qcow2: fix null pointer dereference |
Date: |
Mon, 31 Jul 2017 13:21:29 +0300 |
From: Philippe Mathieu-Daudé <address@hidden>
It seems this assert() was somehow misplaced.
block/qcow2-refcount.c:2193:42: warning: Array access (from variable
'on_disk_reftable') results in a null pointer dereference
on_disk_reftable[refblock_index] = refblock_offset;
~~~~~~~~~~~~~~~~ ^
Reported-by: Clang Static Analyzer
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
---
block/qcow2-refcount.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c
index c9b0dcb4f3..168fc32e7b 100644
--- a/block/qcow2-refcount.c
+++ b/block/qcow2-refcount.c
@@ -2189,6 +2189,8 @@ write_refblocks:
* this will leak that range, but we can easily fix that by running
* a leak-fixing check after this rebuild operation */
reftable_offset = -1;
+ } else {
+ assert(on_disk_reftable);
}
on_disk_reftable[refblock_index] = refblock_offset;
@@ -2258,8 +2260,6 @@ write_refblocks:
goto write_refblocks;
}
- assert(on_disk_reftable);
-
for (refblock_index = 0; refblock_index < reftable_size; refblock_index++)
{
cpu_to_be64s(&on_disk_reftable[refblock_index]);
}
--
2.11.0
- [Qemu-devel] [PULL 00/25 for-2.10] Trivial patches for 2017-07-31, Michael Tokarev, 2017/07/31
- [Qemu-devel] [PULL 07/25] tests: add missing dependency to build QTEST_QEMU_BINARY, Michael Tokarev, 2017/07/31
- [Qemu-devel] [PULL 06/25] qemu-system-tricore: segfault when entering "x 0" on the monitor, Michael Tokarev, 2017/07/31
- [Qemu-devel] [PULL 10/25] qcow2: fix null pointer dereference,
Michael Tokarev <=
- [Qemu-devel] [PULL 09/25] ivshmem: fix incorrect error handling in ivshmem_recv_msg(), Michael Tokarev, 2017/07/31
- [Qemu-devel] [PULL 02/25] fix qemu-system-unicore32 crashing when calling without -kernel, Michael Tokarev, 2017/07/31
- [Qemu-devel] [PULL 12/25] net/eth: fix incorrect check of iov_to_buf() return value, Michael Tokarev, 2017/07/31
- [Qemu-devel] [PULL 08/25] loader: check get_image_size() return value, Michael Tokarev, 2017/07/31
- [Qemu-devel] [PULL 04/25] tests: test-netfilter && pxe-test require slirp, Michael Tokarev, 2017/07/31
- [Qemu-devel] [PULL 16/25] syscall: fix use of uninitialized values, Michael Tokarev, 2017/07/31
- [Qemu-devel] [PULL 13/25] m68k/translate: fix incorrect copy/paste, Michael Tokarev, 2017/07/31
- [Qemu-devel] [PULL 19/25] docs: fix broken paths to docs/interop dir, Michael Tokarev, 2017/07/31
- [Qemu-devel] [PULL 18/25] thunk: assert nb_fields is valid, Michael Tokarev, 2017/07/31
- [Qemu-devel] [PULL 17/25] syscall: check inotify() and eventfd() return value, Michael Tokarev, 2017/07/31