[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v6 5/7] qemu.py: use os.path.null instead of /dev/nu
From: |
Amador Pahim |
Subject: |
[Qemu-devel] [PATCH v6 5/7] qemu.py: use os.path.null instead of /dev/null |
Date: |
Mon, 31 Jul 2017 10:51:08 +0200 |
For increased portability, let's use os.path.devnull.
Signed-off-by: Amador Pahim <address@hidden>
---
scripts/qemu.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/qemu.py b/scripts/qemu.py
index 9434ccc30b..d313c6d4db 100644
--- a/scripts/qemu.py
+++ b/scripts/qemu.py
@@ -80,7 +80,7 @@ class QEMUMachine(object):
fd_param = ["%s" % self._socket_scm_helper,
"%d" % self._qmp.get_sock_fd(),
"%s" % fd_file_path]
- devnull = open('/dev/null', 'rb')
+ devnull = open(os.path.devnull, 'rb')
p = subprocess.Popen(fd_param, stdin=devnull, stdout=sys.stdout,
stderr=sys.stderr)
return p.wait()
@@ -137,7 +137,7 @@ class QEMUMachine(object):
def launch(self):
'''Launch the VM and establish a QMP connection'''
- devnull = open('/dev/null', 'rb')
+ devnull = open(os.path.devnull, 'rb')
qemulog = open(self._qemu_log_path, 'wb')
try:
self._pre_launch()
--
2.13.3
- [Qemu-devel] [PATCH v6 0/7] scripts/qemu.py fixes and cleanups, Amador Pahim, 2017/07/31
- [Qemu-devel] [PATCH v6 2/7] qemu.py: fix is_running() return before first launch(), Amador Pahim, 2017/07/31
- [Qemu-devel] [PATCH v6 3/7] qemu.py: use python logging system, Amador Pahim, 2017/07/31
- [Qemu-devel] [PATCH v6 1/7] qemu.py: use poll() instead of 'returncode', Amador Pahim, 2017/07/31
- [Qemu-devel] [PATCH v6 4/7] qemu.py: improve message on negative exit code, Amador Pahim, 2017/07/31
- [Qemu-devel] [PATCH v6 5/7] qemu.py: use os.path.null instead of /dev/null,
Amador Pahim <=
- [Qemu-devel] [PATCH v6 6/7] qemu.py: cleanup and improve launch()/shutdown(), Amador Pahim, 2017/07/31
- [Qemu-devel] [PATCH v6 7/7] qemu.py: include debug information on launch error, Amador Pahim, 2017/07/31