[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] replay: Define ReplayMode without QAPI
From: |
Pavel Dovgalyuk |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] replay: Define ReplayMode without QAPI |
Date: |
Mon, 31 Jul 2017 09:59:57 +0300 |
> From: Markus Armbruster [mailto:address@hidden
> ReplayMode is defined in the QAPI schema, but not used there. Of the
> stuff QAPI generates for it only the typedef is actually used. Use of
> QAPI is pointless and only complicates things, so don't.
This a bit useless now, but we plan to add more patches that include
QAPI commands for controlling and inspecting the record/replay process.
Pavel Dovgalyuk
>
> Cc: Pavel Dovgalyuk <address@hidden>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> include/sysemu/replay.h | 6 ++++++
> qapi-schema.json | 18 ------------------
> 2 files changed, 6 insertions(+), 18 deletions(-)
>
> diff --git a/include/sysemu/replay.h b/include/sysemu/replay.h
> index fa14d0e..621bc61 100644
> --- a/include/sysemu/replay.h
> +++ b/include/sysemu/replay.h
> @@ -42,6 +42,12 @@ typedef enum ReplayCheckpoint ReplayCheckpoint;
>
> typedef struct ReplayNetState ReplayNetState;
>
> +typedef enum {
> + REPLAY_MODE_NONE, /* replay / record disabled */
> + REPLAY_MODE_RECORD, /* recording to replay log */
> + REPLAY_MODE_PLAY, /* replaying log */
> +} ReplayMode;
> +
> extern ReplayMode replay_mode;
>
> /* Name of the initial VM snapshot */
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 9c6c3e1..9b6f6cb 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -6258,24 +6258,6 @@
> { 'include': 'qapi/rocker.json' }
>
> ##
> -# @ReplayMode:
> -#
> -# Mode of the replay subsystem.
> -#
> -# @none: normal execution mode. Replay or record are not enabled.
> -#
> -# @record: record mode. All non-deterministic data is written into the
> -# replay log.
> -#
> -# @play: replay mode. Non-deterministic data required for system execution
> -# is read from the log.
> -#
> -# Since: 2.5
> -##
> -{ 'enum': 'ReplayMode',
> - 'data': [ 'none', 'record', 'play' ] }
> -
> -##
> # @xen-load-devices-state:
> #
> # Load the state of all devices from file. The RAM and the block devices
> --
> 2.7.5
Re: [Qemu-devel] [PATCH 0/3] Don't QAPI without need, Eric Blake, 2017/07/28