Re: [Qemu-devel] [RFC PATCH 47/47] script to find outdated entry in MAINTAINERS

[Eric Blake]

On 07/28/2017 12:36 AM, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
>  scripts/check_maintainer.sh | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
>  create mode 100755 scripts/check_maintainer.sh
> 

> +echo "Incorrect MAINTAINERS paths:" 1>&2
> +egrep ^F: MAINTAINERS | cut -d\  -f2 | while read p; do
> +    ls -ld $p 1>/dev/null
> +done

Ah, you uses this in a cover letter of your other series, where I
responded without thinking it was going into git.  But now that I see we
are trying to commit it, I really think that one 'ls -l >/dev/null' per
filename is inefficient; this should be

egrep ^F: MAINTAINERS | cut -d\  -f2 | xargs ls -d >/dev/null

if we really like the side effect of ls writing to stdout as the way to
identify globs that no longer map anywhere, or even something like:

for glob in $(egrep ... | cut ...); do
    set - $glob
    if test -n "$2" && ! test -e "$1"; then
        echo "glob $glob no longer resolves" 2>&1
    fi
done

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature