Re: [Qemu-devel] [RFC PATCH 47/47] script to find outdated entry in MAINTAINERS

[Markus Armbruster]

Philippe Mathieu-Daudé <address@hidden> writes:

> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
>  scripts/check_maintainer.sh | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
>  create mode 100755 scripts/check_maintainer.sh
>
> diff --git a/scripts/check_maintainer.sh b/scripts/check_maintainer.sh
> new file mode 100755
> index 0000000000..074a6acf69
> --- /dev/null
> +++ b/scripts/check_maintainer.sh
> @@ -0,0 +1,21 @@
> +#! /bin/bash
> +#
> +# This script checks MAINTAINERS consistency

Consistency?  I think you mean coverage.

> +#
> +# Copyright (C) 2017 Philippe Mathieu-Daudé. GPLv2+.
> +#
> +# Usage:
> +# ./scripts/check_maintainer.sh | tee MAINTAINERS.missing
> +
> +echo "Incorrect MAINTAINERS paths:" 1>&2
> +egrep ^F: MAINTAINERS | cut -d\  -f2 | while read p; do
> +    ls -ld $p 1>/dev/null
> +done
> +
> +echo "No maintainers found for:" 1>&2
> +git ls-files|while read f; do
> +    OUT=$(./scripts/get_maintainer.pl -f $f 2>&1)
> +    if [[ "$OUT" == *"No maintainers found"* ]]; then
> +        echo $f
> +    fi
> +done

Good idea.

But what I really want is checkpatch whining when it happens.  Thomas
posted a patch some time ago.  Would you be willing to revive it?

https://lists.gnu.org/archive/html/qemu-devel/2017-01/msg05742.html
Message-Id: <address@hidden>

Basically:

* Patch deletes a file

  - still in MAINTAINERS after the patch: warn
  - else: ok

* Patch creates a file

  - not in in MAINTAINERS after the patch: warn
  - else: ok

* Patch moves a file

  - old still in MAINTAINERS after the patch: warn
  - new not in in MAINTAINERS after the patch: warn
  - neither: ok

May have to ignore "uninteresting" files to reduce the noise.  But even
ignoring everything but *.[ch] would be an improvement!