[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 07/12] qtest: Add a new helper qmp_cmd() and
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v3 07/12] qtest: Add a new helper qmp_cmd() and friends |
Date: |
Fri, 28 Jul 2017 08:06:18 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 07/28/2017 07:57 AM, Stefan Hajnoczi wrote:
> On Tue, Jul 25, 2017 at 04:15:18PM -0500, Eric Blake wrote:
>> +QDict *qtest_qmp_cmd(QTestState *s, const char *cmd, QObject *args)
>> +{
>> + QDict *dict = qdict_new();
>> +
>> + qdict_put_str(dict, "execute", cmd);
>> + if (args) {
>> + qdict_put_obj(dict, "arguments", args);
>> + }
>> + return qtest_qmp(s, "%p", QOBJECT(dict));
>> +}
>
> qtest_qmp(s, "%p", QOBJECT(dict)) takes ownership of dict?
Hmm, I documented that for qtest_qmp_cmd(), but you have a good
question. I need to double-check that it is true for
qobject_from_jsonf("%p", obj), but my recollection is that yes, wrapping
one object inside the other means freeing the outer object also reclaims
the inner (that is, qobject_from_jsonf wasn't increasing refcount). At
any rate, I'll probably have to submit a followup patch (either to fix
the leak if I'm wrong, or to improve the documentation about %p
reference management if I'm right).
>
> Reviewed-by: Stefan Hajnoczi <address@hidden>
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v3 03/12] qtest: Document calling conventions, (continued)
[Qemu-devel] [PATCH v3 05/12] tests: Clean up string interpolation into QMP input (simple cases), Eric Blake, 2017/07/25
[Qemu-devel] [PATCH v3 06/12] tests/libqos/usb: Clean up string interpolation into QMP input, Eric Blake, 2017/07/25
[Qemu-devel] [PATCH v3 04/12] tests: Pass literal format strings directly to qmp_FOO(), Eric Blake, 2017/07/25
[Qemu-devel] [PATCH v3 07/12] qtest: Add a new helper qmp_cmd() and friends, Eric Blake, 2017/07/25
Re: [Qemu-devel] [PATCH v3 07/12] qtest: Add a new helper qmp_cmd() and friends, Markus Armbruster, 2017/07/28
[Qemu-devel] [PATCH v3 09/12] tests/libqos/pci: Clean up string interpolation into QMP input, Eric Blake, 2017/07/25