[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 05/47] MAINTAINERS: add missing KVM entry
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 05/47] MAINTAINERS: add missing KVM entry |
Date: |
Fri, 28 Jul 2017 14:25:08 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 28/07/2017 14:13, Cornelia Huck wrote:
>>> But would it not a better idea to add an entry for all headers touched
>>> by update-linux-headers, then?
>>
>> One thing doesn't exclude the other. That entry would also list the
>> script itself and linux-headers. KVM, VFIO and virtio patterns can only
>> list the files they care about. Migration could list userfaultfd,
>> possibly. And there's also include/standard-headers/, which includes
>> PCI and input subsystem files... It has to be perfected, but it's a
>> good idea.
>
> Personally, I'm not really a fan. If something is changed in one of the
> headers, it implies that either it has already been changed in the
> original headers in Linux (and I will have seen it then), or that
> someone is sending a preliminary patch (and I should hope that I'm
> already cc:ed for the changes that this headers change is for then). It
> does not really hurt, but it feels wrong.
Sometime people pull changes too early, or otherwise I want to comment
on the timing of the change... I don't know, I already get too much
qemu-devel email. :)
Paolo
- [Qemu-devel] [PATCH 03/47] MAINTAINERS: add missing STM32 entry, (continued)
- [Qemu-devel] [PATCH 03/47] MAINTAINERS: add missing STM32 entry, Philippe Mathieu-Daudé, 2017/07/28
- [Qemu-devel] [PATCH 04/47] MAINTAINERS: add missing USB entry, Philippe Mathieu-Daudé, 2017/07/28
- [Qemu-devel] [PATCH 05/47] MAINTAINERS: add missing KVM entry, Philippe Mathieu-Daudé, 2017/07/28
- Re: [Qemu-devel] [PATCH 05/47] MAINTAINERS: add missing KVM entry, Thomas Huth, 2017/07/28
- Re: [Qemu-devel] [PATCH 05/47] MAINTAINERS: add missing KVM entry, Paolo Bonzini, 2017/07/28
- Re: [Qemu-devel] [PATCH 05/47] MAINTAINERS: add missing KVM entry, Cornelia Huck, 2017/07/28
- Re: [Qemu-devel] [PATCH 05/47] MAINTAINERS: add missing KVM entry, Paolo Bonzini, 2017/07/28
- Re: [Qemu-devel] [PATCH 05/47] MAINTAINERS: add missing KVM entry, Cornelia Huck, 2017/07/28
- Re: [Qemu-devel] [PATCH 05/47] MAINTAINERS: add missing KVM entry,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH 05/47] MAINTAINERS: add missing KVM entry, Cornelia Huck, 2017/07/28
[Qemu-devel] [PATCH 06/47] MAINTAINERS: add missing entry for vhost, Philippe Mathieu-Daudé, 2017/07/28
[Qemu-devel] [PATCH 07/47] MAINTAINERS: add missing entry for vfio/ccw, Philippe Mathieu-Daudé, 2017/07/28
[Qemu-devel] [PATCH 09/47] MAINTAINERS: add missing entry for virtio/9p, Philippe Mathieu-Daudé, 2017/07/28
[Qemu-devel] [PATCH 08/47] MAINTAINERS: add missing entry for virtio, Philippe Mathieu-Daudé, 2017/07/28