[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] trace-events: print 0x before hex numbers
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] trace-events: print 0x before hex numbers |
Date: |
Fri, 28 Jul 2017 13:19:57 +0100 |
On 28 July 2017 at 13:08, Eric Blake <address@hidden> wrote:
> On 07/28/2017 04:04 AM, Peter Maydell wrote:
>> On 28 July 2017 at 09:55, Vladimir Sementsov-Ogievskiy
>> <address@hidden> wrote:
>>> To make logs more readable prefix all hex values with '0x' mark.
>>> This is needed for consistency too, as a lot of hex values are already
>>> prefixed with '0x'. Also, bring all hex outputs to the common form -
>>> use '%#', not '0x%'.
>>>
>>> This patch is done by two commands:
>>> find . -name trace-events | \
>>> xargs sed -i 's/%\([-+
>>> *.0-9]*\([hljztL]\|ll\|hh\)\?\(x\|X\|"\s*PRIx\)\)/%#\1/g'
>
> Why PRIx32 but not PRIX32?
As it happens none of our trace-events files use PRIX...
thanks
-- PMM