Re: [Qemu-devel] [PATCH] fsdev: fix memory leak in main()

[Greg Kurz]

On Thu, 27 Jul 2017 08:31:42 +0800
ZhiPeng Lu <address@hidden> wrote:
> @rpath and @ sock_name are not freed and leaked.
> 

The leak is harmless since the process is expected to terminate when main()
returns. So, even if I fully agree that we should always take care of allocated
memory, I will push it to my 9p-next branch and wait for 2.11 before pushing it
upstream.

> Signed-off-by: Zhipeng Lu address@hidden
> ---
>  fsdev/virtfs-proxy-helper.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c
> index 6c066ec..8e48500 100644
> --- a/fsdev/virtfs-proxy-helper.c
> +++ b/fsdev/virtfs-proxy-helper.c
> @@ -1162,6 +1162,8 @@ int main(int argc, char **argv)
>  
>      process_requests(sock);
>  error:
> +    g_free(rpath);
> +    g_free(sock_name);
>      do_log(LOG_INFO, "Done\n");
>      closelog();
>      return 0;

pgp6cKuD7fism.pgp
Description: OpenPGP digital signature