[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] ui: drop altgr and altgr_r QKeyCodes
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH] ui: drop altgr and altgr_r QKeyCodes |
|
Date: |
Thu, 27 Jul 2017 06:34:55 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 07/27/2017 05:47 AM, Gerd Hoffmann wrote:
> The right alt key (alt_r aka KEY_RIGHTALT) is used for AltGr.
> The altgr and altgr_r keys simply don't exist. Drop them.
>
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
> +++ b/qapi-schema.json
> @@ -4863,13 +4863,14 @@
> # @ac_stop: since 2.10
> # @ac_refresh: since 2.10
> # @ac_bookmarks: since 2.10
> +# altgr, altgr_r: dropped in 2.10
> #
Dropping members is unusual; it may break unsuspecting clients relying
on the names - but the argument is that the keys don't exist, so no one
can have been relying on the name to do anything meaningful.
Reviewed-by: Eric Blake <address@hidden>
and worth inclusion in 2.10
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature