[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] hw/scsi/vmw_pvscsi: Remove the dead error h
From: |
Dmitry Fleytman |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] hw/scsi/vmw_pvscsi: Remove the dead error handling |
Date: |
Wed, 26 Jul 2017 12:48:10 +0300 |
> On 26 Jul 2017, at 11:41 AM, Mao Zhongyi <address@hidden> wrote:
>
> qemu_bh_new() is a wrapper around aio_bh_new(), which returns
> null only when g_new() does. It doesn't. So remove the dead
> error handling.
>
Acked-by: Dmitry Fleytman <address@hidden <mailto:address@hidden>>
> Cc: Dmitry Fleytman <address@hidden>
> Cc: Paolo Bonzini <address@hidden>
> Cc: Markus Armbruster <address@hidden>
> Signed-off-by: Mao Zhongyi <address@hidden>
> ---
> hw/scsi/vmw_pvscsi.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/hw/scsi/vmw_pvscsi.c b/hw/scsi/vmw_pvscsi.c
> index 4a106da..d92973e 100644
> --- a/hw/scsi/vmw_pvscsi.c
> +++ b/hw/scsi/vmw_pvscsi.c
> @@ -1138,10 +1138,6 @@ pvscsi_init(PCIDevice *pci_dev)
> }
>
> s->completion_worker = qemu_bh_new(pvscsi_process_completion_queue, s);
> - if (!s->completion_worker) {
> - pvscsi_cleanup_msi(s);
> - return -ENOMEM;
> - }
>
> scsi_bus_new(&s->bus, sizeof(s->bus), DEVICE(pci_dev),
> &pvscsi_scsi_info, NULL);
> --
> 2.9.4
>
>
>