[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/5] Makefile: clean: Clean exe files
From: |
Michael Roth |
Subject: |
Re: [Qemu-devel] [PATCH 1/5] Makefile: clean: Clean exe files |
Date: |
Tue, 25 Jul 2017 18:10:19 -0500 |
User-agent: |
alot/0.5.1 |
Quoting Peter Maydell (2017-07-23 15:03:56)
> On 5 July 2017 at 08:54, Sameeh Jubran <address@hidden> wrote:
> > From: Sameeh Jubran <address@hidden>
> >
> > Clean exe files such as qemu-ga.exe
> >
> > Signed-off-by: Sameeh Jubran <address@hidden>
> > ---
> > Makefile | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Makefile b/Makefile
> > index 16a0430..22d29d6 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -487,6 +487,7 @@ clean:
> > rm -f config.mak op-i386.h opc-i386.h gen-op-i386.h op-arm.h
> > opc-arm.h gen-op-arm.h
> > rm -f qemu-options.def
> > rm -f *.msi
> > + rm -f *${EXESUF}
>
> On every host OS except Windows, ${EXESUF} is defined
> to be the empty string, which means that this will be
> "rm -f *", which is probably not what we want...
Perhaps something like:
clean:
...
ifneq ($(EXESUF),)
rm -f *${EXESUF}
endif
?
>
> thanks
> -- PMM
>
- [Qemu-devel] [PATCH 0/5] Fix qemu-ga's behaviour on Windows, Sameeh Jubran, 2017/07/05
- [Qemu-devel] [PATCH 2/5] qga-win: service-win32: Add start_service and stop_service functions, Sameeh Jubran, 2017/07/05
- [Qemu-devel] [PATCH 5/5] qga-win: service-win32: Use get_service function, Sameeh Jubran, 2017/07/05
- [Qemu-devel] [PATCH 4/5] qga-win: Add qga-serial-listener to msi installer, Sameeh Jubran, 2017/07/05
- [Qemu-devel] [PATCH 3/5] qga-win: Add serial listener service, Sameeh Jubran, 2017/07/05
- Re: [Qemu-devel] [PATCH 0/5] Fix qemu-ga's behaviour on Windows, Sameeh Jubran, 2017/07/23