Re: [Qemu-devel] [PATCH for 2.10 v2 5/6] docker: don't install device-tree-compiler build-deps in travis.docker

[Alex Bennée]

Philippe Mathieu-Daudé <address@hidden> writes:

> On 07/25/2017 10:34 AM, Alex Bennée wrote:
>> Installing the device-tree-compiler build-deps is a little extreme. We
>> only actually need the binary so include it with the other packages.
>>
>> Suggested-by: Philippe Mathieu-Daudé <address@hidden>
>> Signed-off-by: Alex Bennée <address@hidden>
>
> before:
>
> $ docker images qemu:travis --no-trunc
> --format="{{.Repository}}:{{.Tag}}\t{{.Size}}"
>
> qemu:travis   6.16GB
>
> after:
>
> qemu:travis   5.92GB
>
> not a big win :(
>
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> Tested-by: Philippe Mathieu-Daudé <address@hidden>
>
> (not a "bugfix" btw)

It's arguable - it was certainly wrong as we just need the compiler and
I'm not sure build-dep actually would have pulled it on (although the
qemu build-dep probably does).

>
>> ---
>>   tests/docker/dockerfiles/travis.docker | 3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/tests/docker/dockerfiles/travis.docker 
>> b/tests/docker/dockerfiles/travis.docker
>> index 636fa590a5..57ac8e1419 100644
>> --- a/tests/docker/dockerfiles/travis.docker
>> +++ b/tests/docker/dockerfiles/travis.docker
>> @@ -1,6 +1,5 @@
>>   FROM quay.io/travisci/travis-ruby
>>   RUN apt-get update
>>   RUN apt-get -y build-dep qemu
>> -RUN apt-get -y build-dep device-tree-compiler
>> -RUN apt-get -y install python2.7 python-yaml dh-autoreconf gdb strace lsof 
>> net-tools
>> +RUN apt-get -y install device-tree-compiler python2.7 python-yaml 
>> dh-autoreconf gdb strace lsof net-tools
>>   ENV FEATURES pyyaml
>>


--
Alex Bennée