qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] MAINTAINERS: surprising get_maintainer.pl output for ./


From: Thomas Huth
Subject: Re: [Qemu-devel] MAINTAINERS: surprising get_maintainer.pl output for ./configure
Date: Tue, 25 Jul 2017 07:48:26 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0

On 25.07.2017 00:40, Philippe Mathieu-Daudé wrote:
> Hi perl gurus :)
> 
> after changing the ./configure I wanted to figure to whom email and got
> this:
> 
> $ ./scripts/get_maintainer.pl -f configure
> Kamil Rytarowski <address@hidden> (maintainer:NETBSD)
> address@hidden (open list:All patches CC here)
> 
> $ fgrep -A5 NETBSD MAINTAINERS
> NETBSD
> L: address@hidden
> M: Kamil Rytarowski <address@hidden>
> S: Maintained
> K: (?i)NetBSD
> 
> Descriptions of section entries:
> 
>   K: Keyword perl extended regex pattern to match
>      content in a patch or file.
> 
> $ fgrep -inA1 NetBSD configure
> 547:elif check_define __NetBSD__; then
> 548:  targetos='NetBSD'
> -- 
> 709:NetBSD)
> 710-  bsd="yes"
> -- 
> 715:  HOST_VARIANT_DIR="netbsd"
> 716-  supported_os="yes"
> 
> since ./configure check for NetBSD host/target, the string appears in
> the ./configure and the K regex is matched...
> 
> I tried to add a 'F: configure' in NETBSD entry but it doesn't change.
> The easier is to kill the K entry :)

But without the K: entry there is no more pattern for this entry at all
anymore - since there are also no F: entries here.

I'd suggest to do it the same way as the "Trivial patches" entry:

K: ^Subject:.*(?i)NetBSD

... then it should hopefully only trigger on patch titles.

Philippe, Kamil, if one of you has got some spare minutes, could you
please send a patch?

 Thomas



reply via email to

[Prev in Thread] Current Thread [Next in Thread]