Re: [Qemu-devel] [RFC PATCH 06/26] ppc/xive: introduce a XIVE interrupt source model

[Alexey Kardashevskiy]

On 25/07/17 01:20, Cédric Le Goater wrote:
> On 07/24/2017 08:00 AM, Alexey Kardashevskiy wrote:
>> On 24/07/17 14:02, David Gibson wrote:
>>> On Wed, Jul 05, 2017 at 07:13:19PM +0200, Cédric Le Goater wrote:
>>>> This is very similar to the current ICS_SIMPLE model in XICS. We try
>>>> to reuse the ICS model because the sPAPR machine is tied to the
>>>> XICSFabric interface and should be using a common framework to switch
>>>> from one controller model to another: XICS <-> XIVE.
>>>
>>> Hm.  I'm not entirely concvinced re-using the xics ICSState class in
>>> this way is a good idea, though maybe it's a reasonable first step.
>>> With this patch alone some code is shared, but there are some real
>>> uglies around the edges.
>>
>>
>> Agree, using the "ICS" term in XIVE is quite confusing as "ICS" is not
>> mentioned in neither XIVE nor P9 specs.
> 
> Indeed. 
> 
> The XIVE specs mention Source Controller (P3SC) or Interrupt 
> Virtualization Source Engine (IVSE). The sPAPR specs use 
> Interrupt Source a lot.
> 
> Let's unify them all under one name ? I propose ICS :)


Too late because it is a part of XICS :) Ben calls them "source
controller", seems appropriate.


-- 
Alexey