[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 3/6] target/s390x: implement spm (SET PROGRAM
From: |
David Hildenbrand |
Subject: |
Re: [Qemu-devel] [PATCH v1 3/6] target/s390x: implement spm (SET PROGRAM MASK) |
Date: |
Mon, 24 Jul 2017 19:25:15 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 |
On 24.07.2017 06:39, Richard Henderson wrote:
> On 07/21/2017 05:56 AM, David Hildenbrand wrote:
>> + tcg_gen_extrl_i64_i32(cc, o->in1);
>> + tcg_gen_shri_i32(cc, cc, 28);
>> + tcg_gen_andi_i32(cc, cc, 0x3ul);
>> + tcg_gen_mov_i32(cc_op, cc);
>> + tcg_temp_free_i32(cc);
>> + set_cc_static(s);
>
> tcg_gen_extrl_i64_i32(cc_op, o->in1);
> tcg_gen_extract_i32(cc_op, cc_op, 28, 2);
>
>
My tests still pass with the following suggested hunk.
tcg_gen_extrl_i64_i32(cc_op, o->in1);
tcg_gen_extract_i32(cc_op, cc_op, 28, 2);
set_cc_static(s);
Thanks!
> Otherwise,
>
> Reviewed-by: Richard Henderson <address@hidden>
>
>
> r~
>
--
Thanks,
David
[Qemu-devel] [PATCH v1 5/6] target/s390x: add basic MSA features, David Hildenbrand, 2017/07/21
[Qemu-devel] [PATCH v1 6/6] target/s390x: various alignment check, David Hildenbrand, 2017/07/21
Re: [Qemu-devel] [PATCH v1 0/6] target/s390x: tcg improvments + MSA functions, no-reply, 2017/07/21
Re: [Qemu-devel] [PATCH v1 0/6] target/s390x: tcg improvments + MSA functions, Richard Henderson, 2017/07/23