[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PULL 6/9] Convert error_report() to warn_report()

From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PULL 6/9] Convert error_report() to warn_report()
Date: Mon, 24 Jul 2017 09:30:06 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1

On 24/07/2017 08:30, Markus Armbruster wrote:
> Markus Armbruster <address@hidden> writes:
>> Kevin Wolf <address@hidden> writes:
>>> Am 13.07.2017 um 15:27 hat Markus Armbruster geschrieben:
>>>> From: Alistair Francis <address@hidden>
>>>> Convert all uses of error_report("warning:"... to use warn_report()
>>>> instead. This helps standardise on a single method of printing warnings
>>>> to the user.
>>>> All of the warnings were changed using these two commands:
>>>>     find ./* -type f -exec sed -i \
>>>>       's|error_report(".*warning[,:] |warn_report("|Ig' {} +
>>>> Indentation fixed up manually afterwards.
>>>> The test-qdev-global-props test case was manually updated to ensure that
>>>> this patch passes make check (as the test cases are case sensitive).
>>> This patch broke qemu-iotests 051 because it neglected to update the
>>> reference output. Not sure if a change of the message was even intended,
>>> but with a error location prefix, the order changes:
>>> -(qemu) QEMU_PROG: -drive if=scsi,media=cdrom: warning: bus=0,unit=0 is 
>>> deprecated with this machine type
>>> +(qemu) warning: qemu-system-x86_64: -drive if=scsi,media=cdrom: 
>>> bus=0,unit=0 is deprecated with this machine type
>>> Personally, I would expect the error location or at least the program
>>> name to come first even for warnings.
>> I'll fix it.
>> While focusing on something other than block, I forget qemu-iotests
>> exist.  My fault, but it's a pretty common fault.  I reiterate my plea
>> to include (a sensible subset of) it in "make check".
> Oh, 051 isn't run by "make check-block".  It could just as well not
> exist then.
> What's the recommended way to run all iotests a build of QEMU can run?

I use "path-to-srcdir/tests/check-block.sh".  It takes about 20 minutes.

There are two issues with check-block:

* tests that require QEMU are skipped (rationale: you might be building
without the x86_64-softmmu target).

* it only runs the "quick" group, but I think we should reverse the
direction and mark slow tests specifically (that would cut about 10
minutes out of the 20).

It's a pity that qemu-iotests doesn't parallelize.  Maybe the harness
could be changed to something more standard.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]