[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 9/9] tests/libqtest: Enable compile-time format
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 9/9] tests/libqtest: Enable compile-time format string checking |
Date: |
Fri, 21 Jul 2017 10:04:42 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 07/21/2017 08:53 AM, Markus Armbruster wrote:
> qtest_qmp() & friends pass their format string and variable arguments
> to qobject_from_jsonv(). Unlike qobject_from_jsonv(), they aren't
> decorated with GCC_FMT_ATTR(). Fix that to get compile-time format
> string checking.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> tests/libqtest.h | 40 ++++++++++++++++++++++++----------------
> 1 file changed, 24 insertions(+), 16 deletions(-)
Don't know how much of this to merge with my fixed version of 2/9. But
matches what I had locally after my version 1, before I ripped it all
back out again prior to posting my v2 when dealing with gcc fallout,
that you've now corrected.
> @@ -65,7 +66,8 @@ void qtest_qmp_discard_response(QTestState *s, const char
> *fmt, ...);
> *
> * Sends a QMP message to QEMU and returns the response.
> */
> -QDict *qtest_qmp(QTestState *s, const char *fmt, ...);
> +QDict *qtest_qmp(QTestState *s, const char *fmt, ...)
> + GCC_FMT_ATTR(2, 3);
This would fit on one line; any reason we need the line wrap?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 2/9] qtest: Document calling conventions, (continued)