[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 11/11] qtest.py: Avoid using mutable list as def
|
From: |
Lukáš Doktor |
|
Subject: |
Re: [Qemu-devel] [PATCH 11/11] qtest.py: Avoid using mutable list as default argument |
|
Date: |
Fri, 21 Jul 2017 08:58:59 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
Dne 20.7.2017 v 20:44 Eduardo Habkost napsal(a):
> On Thu, Jul 20, 2017 at 06:28:15PM +0200, Lukáš Doktor wrote:
>> The list is a mutable object and is dangerous to use it. Recently the
>> QEMUMachine was adjusted to allow None as default, let's use it here as
>> well.
>>
>> Signed-off-by: Lukáš Doktor <address@hidden>
>
> This patch requires patch 02/11 and both are pretty small.
> I suggest squashing them together.
>
Sure, I'll change it in the v2.
Lukáš
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 00/11] qemu.py: Pylint/style fixes, Lukáš Doktor, 2017/07/20
- [Qemu-devel] [PATCH 04/11] qemu.py: Simplify QMP key-conversion, Lukáš Doktor, 2017/07/20
- [Qemu-devel] [PATCH 11/11] qtest.py: Avoid using mutable list as default argument, Lukáš Doktor, 2017/07/20
- [Qemu-devel] [PATCH 03/11] qemu.py: Use iteritems rather than keys(), Lukáš Doktor, 2017/07/20
- [Qemu-devel] [PATCH 02/11] qemu.py: Avoid dangerous arguments, Lukáš Doktor, 2017/07/20
- [Qemu-devel] [PATCH 08/11] qmp.py: Avoid "has_key" usage, Lukáš Doktor, 2017/07/20
- [Qemu-devel] [PATCH 05/11] qemu.py: Use custom exceptions rather than Exception, Lukáš Doktor, 2017/07/20