[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 0/4] Ide patches
From: |
John Snow |
Subject: |
Re: [Qemu-devel] [PULL 0/4] Ide patches |
Date: |
Tue, 18 Jul 2017 17:31:51 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 07/18/2017 05:27 PM, address@hidden wrote:
> Hi,
>
> This series seems to have some coding style problems. See output below for
> more information:
>
> Subject: [Qemu-devel] [PULL 0/4] Ide patches
> Message-id: address@hidden
> Type: series
>
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
>
> BASE=base
> n=1
> total=$(git log --oneline $BASE.. | wc -l)
> failed=0
>
> git config --local diff.renamelimit 0
> git config --local diff.renames True
>
> commits="$(git log --format=%H --reverse $BASE..)"
> for c in $commits; do
> echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
> if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -;
> then
> failed=1
> echo
> fi
> n=$((n+1))
> done
>
> exit $failed
> === TEST SCRIPT END ===
>
> Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
> Switched to a new branch 'test'
> 02dcdb3 tests/ahci-test: Be mean with RAM
> e94eb50 ahci: split public and private interface
> cb2c639 ahci: Isolate public AHCI interface
> d77a741 ahci: add ahci_get_num_ports
>
> === OUTPUT BEGIN ===
> Checking PATCH 1/4: ahci: add ahci_get_num_ports...
> Checking PATCH 2/4: ahci: Isolate public AHCI interface...
> ERROR: spaces required around that '/' (ctx:VxV)
> #221: FILE: include/hw/ide/ahci_public.h:88:
> + uint32_t regs[ALLWINNER_AHCI_MMIO_SIZE/4];
> ^
>
> total: 1 errors, 0 warnings, 189 lines checked
>
> Your patch has style problems, please review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
>
> Checking PATCH 3/4: ahci: split public and private interface...
> ERROR: spaces required around that '/' (ctx:VxV)
> #800: FILE: include/hw/ide/ahci.h:88:
> + uint32_t regs[ALLWINNER_AHCI_MMIO_SIZE/4];
> ^
>
> total: 1 errors, 0 warnings, 760 lines checked
>
> Your patch has style problems, please review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
>
> Checking PATCH 4/4: tests/ahci-test: Be mean with RAM...
> === OUTPUT END ===
>
> Test command exited with code: 1
>
>
> ---
> Email generated automatically by Patchew [http://patchew.org/].
> Please send your feedback to address@hidden
>
IMO, false positive on code movement, but I could fix this up if desired.
--js
- [Qemu-devel] [PULL 0/4] Ide patches, John Snow, 2017/07/18
- [Qemu-devel] [PULL 1/4] ahci: add ahci_get_num_ports, John Snow, 2017/07/18
- [Qemu-devel] [PULL 2/4] ahci: Isolate public AHCI interface, John Snow, 2017/07/18
- [Qemu-devel] [PULL 3/4] ahci: split public and private interface, John Snow, 2017/07/18
- [Qemu-devel] [PULL 4/4] tests/ahci-test: Be mean with RAM, John Snow, 2017/07/18
- Re: [Qemu-devel] [PULL 0/4] Ide patches, no-reply, 2017/07/18
- Re: [Qemu-devel] [PULL 0/4] Ide patches,
John Snow <=
- Re: [Qemu-devel] [PULL 0/4] Ide patches, Peter Maydell, 2017/07/19