[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 02/16] migration: Close file on failed migration load
From: |
Juan Quintela |
Subject: |
[Qemu-devel] [PULL 02/16] migration: Close file on failed migration load |
Date: |
Tue, 18 Jul 2017 17:41:13 +0200 |
From: "Dr. David Alan Gilbert" <address@hidden>
Closing the file before exit on a failure allows
the source to cleanup better, especially with RDMA.
Partial fix for https://bugs.launchpad.net/qemu/+bug/1545052
Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Peter Xu <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>
---
migration/migration.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/migration/migration.c b/migration/migration.c
index a0db40d..8552f54 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -348,6 +348,7 @@ static void process_incoming_migration_co(void *opaque)
migrate_set_state(&mis->state, MIGRATION_STATUS_ACTIVE,
MIGRATION_STATUS_FAILED);
error_report("load of migration failed: %s", strerror(-ret));
+ qemu_fclose(mis->from_src_file);
exit(EXIT_FAILURE);
}
mis->bh = qemu_bh_new(process_incoming_migration_bh, mis);
--
2.9.4
- [Qemu-devel] [PULL 00/16] Migration, Juan Quintela, 2017/07/18
- [Qemu-devel] [PULL 02/16] migration: Close file on failed migration load,
Juan Quintela <=
- [Qemu-devel] [PULL 01/16] migration/rdma: Fix race on source, Juan Quintela, 2017/07/18
- [Qemu-devel] [PULL 03/16] migration/rdma: fix qemu_rdma_block_for_wrid error paths, Juan Quintela, 2017/07/18
- [Qemu-devel] [PULL 04/16] migration/rdma: Allow cancelling while waiting for wrid, Juan Quintela, 2017/07/18
- [Qemu-devel] [PULL 05/16] migration/rdma: Safely convert control types, Juan Quintela, 2017/07/18
- [Qemu-devel] [PULL 06/16] migration/rdma: Send error during cancelling, Juan Quintela, 2017/07/18
- [Qemu-devel] [PULL 07/16] qdev: provide DEFINE_PROP_INT64(), Juan Quintela, 2017/07/18
- [Qemu-devel] [PULL 09/16] migration: export capabilities to props, Juan Quintela, 2017/07/18
- [Qemu-devel] [PULL 08/16] migration: export parameters to props, Juan Quintela, 2017/07/18
- [Qemu-devel] [PULL 10/16] migration: introduce migrate_params_check(), Juan Quintela, 2017/07/18
- [Qemu-devel] [PULL 11/16] migration: provide migrate_params_apply(), Juan Quintela, 2017/07/18