[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 22/29] vmsvga: use ARRAY_SIZE macro
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-devel] [PATCH 22/29] vmsvga: use ARRAY_SIZE macro |
Date: |
Tue, 18 Jul 2017 04:28:48 -0700 |
On Mon, Jul 17, 2017 at 11:09 PM, Philippe Mathieu-Daudé
<address@hidden> wrote:
> Applied using the Coccinelle semantic patch scripts/coccinelle/use_osdep.cocci
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
> ---
>
> No entry in MAINTAINERS, should it go under Graphics or Vmware?
>
> hw/display/vmware_vga.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/hw/display/vmware_vga.c b/hw/display/vmware_vga.c
> index 4a64b41259..ff8130ff70 100644
> --- a/hw/display/vmware_vga.c
> +++ b/hw/display/vmware_vga.c
> @@ -679,10 +679,9 @@ static void vmsvga_fifo_run(struct vmsvga_state_s *s)
> if (cursor.width > 256
> || cursor.height > 256
> || cursor.bpp > 32
> - || SVGA_BITMAP_SIZE(x, y)
> - > sizeof(cursor.mask) / sizeof(cursor.mask[0])
> + || SVGA_BITMAP_SIZE(x, y) > ARRAY_SIZE(cursor.mask)
> || SVGA_PIXMAP_SIZE(x, y, cursor.bpp)
> - > sizeof(cursor.image) / sizeof(cursor.image[0])) {
> + > ARRAY_SIZE(cursor.image)) {
> goto badcmd;
> }
>
> --
> 2.13.2
>
>
--
Marc-André Lureau
- [Qemu-devel] [PATCH 18/29] nios2: use QEMU_IS_ALIGNED macro, (continued)
- [Qemu-devel] [PATCH 18/29] nios2: use QEMU_IS_ALIGNED macro, Philippe Mathieu-Daudé, 2017/07/18
- [Qemu-devel] [PATCH 19/29] disas: use QEMU_IS_ALIGNED macro, Philippe Mathieu-Daudé, 2017/07/18
- [Qemu-devel] [PATCH 20/29] disas: use ARRAY_SIZE macro, Philippe Mathieu-Daudé, 2017/07/18
- [Qemu-devel] [PATCH 21/29] qga: use ARRAY_SIZE macro, Philippe Mathieu-Daudé, 2017/07/18
- [Qemu-devel] [PATCH 22/29] vmsvga: use ARRAY_SIZE macro, Philippe Mathieu-Daudé, 2017/07/18
- Re: [Qemu-devel] [PATCH 22/29] vmsvga: use ARRAY_SIZE macro,
Marc-André Lureau <=
- [Qemu-devel] [PATCH 23/29] async: use ARRAY_SIZE macro, Philippe Mathieu-Daudé, 2017/07/18
- [Qemu-devel] [PATCH 24/29] tests/acpi: use ARRAY_SIZE macro, Philippe Mathieu-Daudé, 2017/07/18
- [Qemu-devel] [PATCH 25/29] libqos: use ARRAY_SIZE macro, Philippe Mathieu-Daudé, 2017/07/18
- [Qemu-devel] [PATCH 26/29] tests/tcg: use ARRAY_SIZE macro, Philippe Mathieu-Daudé, 2017/07/18