Re: [Qemu-devel] [PATCH v2 2/9] hw/char/cmsdk-apb-uart.c: Implement CMSDK APB UART

[Philippe Mathieu-Daudé]

Hi Peter,

On 07/14/2017 07:51 AM, Peter Maydell wrote:
> Implement a model of the simple "APB UART" provided in
> the Cortex-M System Design Kit (CMSDK).
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
>   hw/char/Makefile.objs            |   1 +
>   include/hw/char/cmsdk-apb-uart.h |  78 ++++++++
>   hw/char/cmsdk-apb-uart.c         | 402 +++++++++++++++++++++++++++++++++++++++
>   default-configs/arm-softmmu.mak  |   2 +
>   hw/char/trace-events             |   9 +
>   5 files changed, 492 insertions(+)
>   create mode 100644 include/hw/char/cmsdk-apb-uart.h
>   create mode 100644 hw/char/cmsdk-apb-uart.c
>
> diff --git a/hw/char/Makefile.objs b/hw/char/Makefile.objs
> index 55fcb68..1bcd37e 100644
> --- a/hw/char/Makefile.objs
> +++ b/hw/char/Makefile.objs
> @@ -19,6 +19,7 @@ obj-$(CONFIG_DIGIC) += digic-uart.o
>   obj-$(CONFIG_STM32F2XX_USART) += stm32f2xx_usart.o
>   obj-$(CONFIG_RASPI) += bcm2835_aux.o
>   
> +common-obj-$(CONFIG_CMSDK_APB_UART) += cmsdk-apb-uart.o
>   common-obj-$(CONFIG_ETRAXFS) += etraxfs_ser.o
>   common-obj-$(CONFIG_ISA_DEBUG) += debugcon.o
>   common-obj-$(CONFIG_GRLIB) += grlib_apbuart.o
[...]> diff --git a/default-configs/arm-softmmu.mak 
b/default-configs/arm-softmmu.mak
> index bfd2a88..d128e9d 100644
> --- a/default-configs/arm-softmmu.mak
> +++ b/default-configs/arm-softmmu.mak
> @@ -96,6 +96,8 @@ CONFIG_STM32F2XX_ADC=y
>   CONFIG_STM32F2XX_SPI=y
>   CONFIG_STM32F205_SOC=y
>   
> +CONFIG_CMSDK_APB_UART=y

I'd prefer:

CONFIG_CMSDK_APB_UART=$(CONFIG_MPS2)

> +
>   CONFIG_VERSATILE_PCI=y
>   CONFIG_VERSATILE_I2C=y
[...]