[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 0/6] fsdev: qmp interface for io throttling
From: |
Pradeep Jagadeesh |
Subject: |
Re: [Qemu-devel] [PATCH v7 0/6] fsdev: qmp interface for io throttling |
Date: |
Fri, 14 Jul 2017 15:15:06 +0200 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
Hi Manos,
Thanks for sharing the link to your code patch.
On 7/14/2017 2:22 PM, Manos Pitsidianakis wrote:
Hello Pradeep, you might be interested in my work on refactoring the
block layer's throttling interface in my series:
https://lists.nongnu.org/archive/html/qemu-devel/2017-07/msg04191.html
Sure will have a look.
In this series you copy the existing legacy interface we want to get rid
of. I think it will be easier work for you to use the changes introduced
in my patches when they are merged.
So, should I wait till they are in?. Actually my throttle patches for
fsdev are already upstream (2.9). Now I am just introducing the qmp/hmp
interfaces for the same.
Have you thought about using throttle groups? It'd mean many devices
sharing the same limits. This way the interfaces can be unified. Please
read docs/throttle.txt and see if it would be useful for you.
I have read about the throttle group, last year when I was implementing
the throttle feature for fsdev.My open source work depends on the
projects I/my group work on. So, when I have more bandwidth work on
those, I will surely take it up. Throttle group option may be useful
feature even in case of fsdev devices.
Regards,
Pradeep
- [Qemu-devel] [PATCH v7 1/6] throttle: factor out duplicate code, (continued)