[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] qdev: provide DEFINE_PROP_INT64()
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] qdev: provide DEFINE_PROP_INT64() |
Date: |
Fri, 14 Jul 2017 11:06:27 +0800 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Thu, Jul 13, 2017 at 04:05:32PM +0000, Marc-André Lureau wrote:
[...]
> > diff --git a/include/hw/qdev-properties.h b/include/hw/qdev-properties.h
> > index 0604c33..2939614 100644
> > --- a/include/hw/qdev-properties.h
> > +++ b/include/hw/qdev-properties.h
> > @@ -13,6 +13,7 @@ extern PropertyInfo qdev_prop_uint16;
> > extern PropertyInfo qdev_prop_uint32;
> > extern PropertyInfo qdev_prop_int32;
> > extern PropertyInfo qdev_prop_uint64;
> > +extern PropertyInfo qdev_prop_int64;
> > extern PropertyInfo qdev_prop_size;
> > extern PropertyInfo qdev_prop_string;
> > extern PropertyInfo qdev_prop_chr;
> > @@ -127,6 +128,8 @@ extern PropertyInfo qdev_prop_arraylen;
> > DEFINE_PROP_SIGNED(_n, _s, _f, _d, qdev_prop_int32, int32_t)
> > #define DEFINE_PROP_UINT64(_n, _s, _f, _d) \
> > DEFINE_PROP_UNSIGNED(_n, _s, _f, _d, qdev_prop_uint64, uint64_t)
> > +#define DEFINE_PROP_INT64(_n, _s, _f, _d) \
> > + DEFINE_PROP_UNSIGNED(_n, _s, _f, _d, qdev_prop_int64, int64_t)
> >
>
>
> Make it SIGNED, with that:
Oops, definitely.
>
> Reviewed-by: Marc-André Lureau <address@hidden>
Thanks!
--
Peter Xu